adarshsanjeev commented on code in PR #14527:
URL: https://github.com/apache/druid/pull/14527#discussion_r1254281799
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/destination/DataSourceMSQDestination.java:
##########
@@ -35,7 +36,7 @@
public class DataSourceMSQDestination implements MSQDestination
Review Comment:
Is there a reason to not move MSQDestination to
`org.apache.druid.msq.indexing.destination` as well?
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/WorkerImpl.java:
##########
@@ -1319,7 +1342,7 @@ private void writeDurableStorageSuccessFileIfNeeded(final
int stageNumber)
e,
"Unable to create the success file [%s] at the location [%s]",
DurableStorageUtils.SUCCESS_MARKER_FILENAME,
- DurableStorageUtils.getSuccessFilePath(
+ DurableStorageUtils.getWorkerOutputSuccessFilePath(
Review Comment:
Should we get the worker output path from the
DurableStorageOutputChannelFactory instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
