ektravel commented on code in PR #14529:
URL: https://github.com/apache/druid/pull/14529#discussion_r1256272744


##########
docs/development/extensions-core/kinesis-ingestion.md:
##########
@@ -269,100 +273,91 @@ For more information, see [Data 
formats](../../ingestion/data-formats.md). You c
 
 ### `tuningConfig`
 
-The `tuningConfig` is optional. If no `tuningConfig` is specified, default 
parameters are used.
-
-|Field|Type|Description|Required|
-|-----|----|-----------|--------|
-|`type`| String|The indexing task type, this should always be `kinesis`.|yes|
-|`maxRowsInMemory`|Integer|The number of rows to aggregate before persisting. 
This number is the post-aggregation rows, so it is not equivalent to the number 
of input events, but the number of aggregated rows that those events result in. 
This is used to manage the required JVM heap size. Maximum heap memory usage 
for indexing scales with `maxRowsInMemory * (2 + maxPendingPersists)`.|no 
(default == 100000)|
-|`maxBytesInMemory`|Long| The number of bytes to aggregate in heap memory 
before persisting. This is based on a rough estimate of memory usage and not 
actual usage. Normally, this is computed internally and user does not need to 
set it. The maximum heap memory usage for indexing is `maxBytesInMemory * (2 + 
maxPendingPersists)`.|no (default == One-sixth of max JVM memory)|
-|`maxRowsPerSegment`|Integer|The number of rows to aggregate into a segment; 
this number is post-aggregation rows. Handoff will happen either if 
`maxRowsPerSegment` or `maxTotalRows` is hit or every 
`intermediateHandoffPeriod`, whichever happens earlier.|no (default == 5000000)|
-|`maxTotalRows`|Long|The number of rows to aggregate across all segments; this 
number is post-aggregation rows. Handoff will happen either if 
`maxRowsPerSegment` or `maxTotalRows` is hit or every 
`intermediateHandoffPeriod`, whichever happens earlier.|no (default == 
unlimited)|
-|`intermediatePersistPeriod`|ISO8601 Period|The period that determines the 
rate at which intermediate persists occur.|no (default == PT10M)|
-|`maxPendingPersists`|Integer|Maximum number of persists that can be pending 
but not started. If this limit would be exceeded by a new intermediate persist, 
ingestion will block until the currently-running persist finishes. Maximum heap 
memory usage for indexing scales with `maxRowsInMemory * (2 + 
maxPendingPersists)`.|no (default == 0, meaning one persist can be running 
concurrently with ingestion, and none can be queued up)|
-|`indexSpec`|Object|Tune how data is indexed. See [IndexSpec](#indexspec) for 
more information.|no|
-|`indexSpecForIntermediatePersists`|Object|Defines segment storage format 
options to be used at indexing time for intermediate persisted temporary 
segments. This can be used to disable dimension/metric compression on 
intermediate segments to reduce memory required for final merging. However, 
disabling compression on intermediate segments might increase page cache use 
while they are used before getting merged into final segment published, see 
[IndexSpec](#indexspec) for possible values.| no (default = same as 
`indexSpec`)|
-|`reportParseExceptions`|Boolean|If true, exceptions encountered during 
parsing will be thrown and will halt ingestion; if false, unparseable rows and 
fields will be skipped.|no (default == false)|
-|`handoffConditionTimeout`|Long| Milliseconds to wait for segment handoff. It 
must be >= 0, where 0 means to wait forever.| no (default == 0)|
-|`resetOffsetAutomatically`|Boolean|Controls behavior when Druid needs to read 
Kinesis messages that are no longer available.<br/><br/>If false, the exception 
bubbles up, causing tasks to fail and ingestion to halt. If this occurs, manual 
intervention is required to correct the situation, potentially using the [Reset 
Supervisor API](../../api-reference/supervisor-api.md). This mode is useful for 
production, since it highlights issues with ingestion.<br/><br/>If true, Druid 
automatically resets to the earliest or latest sequence number available in 
Kinesis, based on the value of the `useEarliestSequenceNumber` property 
(earliest if true, latest if false). Note that this can lead to data being 
*DROPPED* (if `useEarliestSequenceNumber` is false) or *DUPLICATED* (if 
`useEarliestSequenceNumber` is true) without your knowledge. Druid will log 
messages indicating that a reset has occurred without interrupting ingestion. 
This mode is useful for non-production situations since it enables Dru
 id to recover from problems automatically, even if they lead to quiet dropping 
or duplicating of data.|no (default == false)|
-|`skipSequenceNumberAvailabilityCheck`|Boolean|Whether to enable checking if 
the current sequence number is still available in a particular Kinesis shard. 
If set to false, the indexing task will attempt to reset the current sequence 
number (or not), depending on the value of `resetOffsetAutomatically`.|no 
(default == false)|
-|`workerThreads`|Integer|The number of threads that the supervisor uses to 
handle requests/responses for worker tasks, along with any other internal 
asynchronous operation.|no (default == min(10, taskCount))|
-|`chatAsync`|Boolean| If true, the supervisor uses asynchronous communication 
with indexing tasks and ignores the `chatThreads` parameter. If false, the 
supervisor uses synchronous communication in a thread pool of size 
`chatThreads`.| no (default == true)|
-|`chatThreads`|Integer| The number of threads that will be used for 
communicating with indexing tasks. Ignored if `chatAsync` is `true` (the 
default).| no (default == min(10, taskCount * replicas))|
-|`chatRetries`|Integer|The number of times HTTP requests to indexing tasks 
will be retried before considering tasks unresponsive.| no (default == 8)|
-|`httpTimeout`|ISO8601 Period|How long to wait for a HTTP response from an 
indexing task.|no (default == PT10S)|
-|`shutdownTimeout`|ISO8601 Period|How long to wait for the supervisor to 
attempt a graceful shutdown of tasks before exiting.|no (default == PT80S)|
-|`recordBufferSize`|Integer|Size of the buffer (number of events) used between 
the Kinesis fetch threads and the main ingestion thread.|no (see [Determining 
fetch settings](#determining-fetch-settings) for defaults)|
-|`recordBufferOfferTimeout`|Integer|Length of time in milliseconds to wait for 
space to become available in the buffer before timing out.| no (default == 
5000)|
-|`recordBufferFullWait`|Integer|Length of time in milliseconds to wait for the 
buffer to drain before attempting to fetch records from Kinesis again.|no 
(default == 5000)|
-|`fetchThreads`|Integer|Size of the pool of threads fetching data from 
Kinesis. There is no benefit in having more threads than Kinesis shards.|no 
(default == procs * 2, where `procs` is the number of processors available to 
the task)|
-|`segmentWriteOutMediumFactory`|Object|Segment write-out medium to use when 
creating segments. See below for more information.|no (not specified by 
default, the value from `druid.peon.defaultSegmentWriteOutMediumFactory.type` 
is used)|
-|`intermediateHandoffPeriod`|ISO8601 Period|How often the tasks should hand 
off segments. Handoff will happen either if `maxRowsPerSegment` or 
`maxTotalRows` is hit or every `intermediateHandoffPeriod`, whichever happens 
earlier.| no (default == P2147483647D)|
-|`logParseExceptions`|Boolean|If true, log an error message when a parsing 
exception occurs, containing information about the row where the error 
occurred.|no, default == false|
-|`maxParseExceptions`|Integer|The maximum number of parse exceptions that can 
occur before the task halts ingestion and fails. Overridden if 
`reportParseExceptions` is set.|no, unlimited default|
-|`maxSavedParseExceptions`|Integer|When a parse exception occurs, Druid can 
keep track of the most recent parse exceptions. "maxSavedParseExceptions" 
limits how many exception instances will be saved. These saved exceptions will 
be made available after the task finishes in the [task completion 
report](../../ingestion/tasks.md#task-reports). Overridden if 
`reportParseExceptions` is set.|no, default == 0|
-|`maxRecordsPerPoll`|Integer|The maximum number of records/events to be 
fetched from buffer per poll. The actual maximum will be 
`Max(maxRecordsPerPoll, Max(bufferSize, 1))`|no (see [Determining fetch 
settings](#determining-fetch-settings) for defaults)|
-|`repartitionTransitionDuration`|ISO8601 period|When shards are split or 
merged, the supervisor recomputes shard to task group mappings. The supervisor 
also signals any running tasks created under the old mappings to stop early at 
(current time + `repartitionTransitionDuration`). Stopping the tasks early 
allows Druid to begin reading from the new shards more quickly. The repartition 
transition wait time controlled by this property gives the stream additional 
time to write records to the new shards after the split or merge, which helps 
avoid issues with [empty shard 
handling](https://github.com/apache/druid/issues/7600).|no, (default == PT2M)|
-|`offsetFetchPeriod`|ISO8601 period|How often the supervisor queries Kinesis 
and the indexing tasks to fetch current offsets and calculate lag. If the 
user-specified value is below the minimum value (`PT5S`), the supervisor 
ignores the value and uses the minimum value instead.|no (default == PT30S, min 
== PT5S)|
-|`useListShards`|Boolean|Indicates if `listShards` API of AWS Kinesis SDK can 
be used to prevent `LimitExceededException` during ingestion. Please note that 
the necessary `IAM` permissions must be set for this to work.|no (default == 
false)|
+The `tuningConfig` parameter is optional. If you don't specify `tuningConfig`, 
Druid uses default parameters.

Review Comment:
   Updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to