abhishekagarwal87 opened a new pull request, #14576:
URL: https://github.com/apache/druid/pull/14576

   This PR uses the QoSFilter available in Jetty to park the query requests 
that exceed a configured limit. This is done so that other HTTP requests such 
as health check calls do not get blocked if the query server is busy serving 
long-running queries. The same mechanism can also be used in the future to 
isolate interactive queries from long-running select queries from interactive 
queries within the same broker. 
   
   Parked requests are timed out after 30 seconds by default. I overrode that 
to 5 minutes in this PR though we probably want that to be configurable. 
   
   I tested it on a local cluster and verified that it works. Though it 
requires a bit of polishing. So marking it draft. 
   
   This PR has:
   
   - [ ] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] a release note entry in the PR description.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to