gianm commented on PR #14567: URL: https://github.com/apache/druid/pull/14567#issuecomment-1632642729
@LakshSingla I think you're right that the exception should ideally be a `DEFENSIVE`. We expect this never to happen, which is classic defensive. The fact that it was seen at one point is a bug that this PR fixes. My only note really would be that, IMO, the "Treat this exception as a bug…" is unnecessary. I'm not sure if we want the message, but if we do, it would actually make sense on _every_ `DEFENSIVE` exception so would make more sense to bake into the `DEFENSIVE` exception generator or mapper itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
