zachjsh commented on code in PR #14560: URL: https://github.com/apache/druid/pull/14560#discussion_r1261495289
########## processing/src/main/java/org/apache/druid/query/metadata/SegmentMetadataQueryQueryToolChest.java: ########## @@ -254,10 +256,10 @@ public <T extends LogicalSegment> List<T> filterSegments(SegmentMetadataQuery qu @VisibleForTesting public static SegmentAnalysis mergeAnalyses( - @Nullable String dataSource, + Set<String> dataSources, Review Comment: why use all datasources now, instead of first as before? I believe that the SegmentAnalysis is for single table? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
