zachjsh commented on code in PR #14560:
URL: https://github.com/apache/druid/pull/14560#discussion_r1261497520
##########
processing/src/main/java/org/apache/druid/query/metadata/SegmentMetadataQueryQueryToolChest.java:
##########
@@ -309,7 +325,7 @@ public static SegmentAnalysis mergeAnalyses(
final Map<String, AggregatorFactory> aggregators = new HashMap<>();
- if (lenientAggregatorMerge) {
+ if (AggregatorMergeStrategy.LENIENT == aggregatorMergeStrategy) {
// Merge each aggregator individually, ignoring nulls
for (SegmentAnalysis analysis : ImmutableList.of(arg1, arg2)) {
Review Comment:
cant either arg1 and arg2 technically be null here based on logic above? I
think that will result in exception here if so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
