zachjsh commented on code in PR #14560:
URL: https://github.com/apache/druid/pull/14560#discussion_r1261499607
##########
processing/src/main/java/org/apache/druid/query/metadata/SegmentMetadataQueryQueryToolChest.java:
##########
@@ -254,10 +256,10 @@ public <T extends LogicalSegment> List<T>
filterSegments(SegmentMetadataQuery qu
@VisibleForTesting
public static SegmentAnalysis mergeAnalyses(
- @Nullable String dataSource,
+ Set<String> dataSources,
Review Comment:
Oh I see, its equivalent to before since the first datasource is checked
first, and now we have added protection that if first segment didn't belong to
first dataSource in list but to a subsequent one, then merge analysis will
still work.
##########
processing/src/main/java/org/apache/druid/query/metadata/SegmentMetadataQueryQueryToolChest.java:
##########
@@ -309,7 +325,7 @@ public static SegmentAnalysis mergeAnalyses(
final Map<String, AggregatorFactory> aggregators = new HashMap<>();
- if (lenientAggregatorMerge) {
+ if (AggregatorMergeStrategy.LENIENT == aggregatorMergeStrategy) {
// Merge each aggregator individually, ignoring nulls
for (SegmentAnalysis analysis : ImmutableList.of(arg1, arg2)) {
Review Comment:
Issue existed before, nvm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
