abhishekrb19 commented on code in PR #14560: URL: https://github.com/apache/druid/pull/14560#discussion_r1261502281
########## processing/src/main/java/org/apache/druid/query/metadata/SegmentMetadataQueryQueryToolChest.java: ########## @@ -254,10 +256,10 @@ public <T extends LogicalSegment> List<T> filterSegments(SegmentMetadataQuery qu @VisibleForTesting public static SegmentAnalysis mergeAnalyses( - @Nullable String dataSource, + Set<String> dataSources, Review Comment: yeah, this is for `UnionDataSource` - previously, the caller was passing only the first one [here](https://github.com/apache/druid/pull/14560/files#diff-acc53e0e891879963c30d5c8b349347f6b7d96c0560992a3c8fe1f9f3d2ddd3bL142). Now we pass in all the datasources and determine the datasource in this function -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
