abhishekrb19 commented on code in PR #14560:
URL: https://github.com/apache/druid/pull/14560#discussion_r1261547524
##########
processing/src/main/java/org/apache/druid/query/metadata/SegmentMetadataQueryQueryToolChest.java:
##########
@@ -369,7 +399,7 @@ public static SegmentAnalysis mergeAnalyses(
if (arg1.getId() != null && arg2.getId() != null &&
arg1.getId().equals(arg2.getId())) {
mergedId = arg1.getId();
} else {
- mergedId = "merged";
+ mergedId = mergedSegmentId == null ? "merged" :
mergedSegmentId.toString();
Review Comment:
>Does the SegmentId.tryParse function return same result for a given
datasource in each case?
Yes, there's some good test coverage for this
[here](https://github.com/apache/druid/blob/master/processing/src/test/java/org/apache/druid/timeline/SegmentIdTest.java#L86).
It'll return null if the segment id cannot be parsed for whatever reason
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
