clintropolis commented on code in PR #14540:
URL: https://github.com/apache/druid/pull/14540#discussion_r1263167124
##########
web-console/src/views/home-view/segments-card/segments-card.tsx:
##########
@@ -60,17 +66,22 @@ FROM sys.segments`,
);
return {
- total: availableSegmentNum + unavailableSegmentNum,
+ active: availableSegmentNum + unavailableSegmentNum,
+ cached_on_historical: availableSegmentNum, // This is not correct
Review Comment:
?
##########
web-console/src/utils/druid-query.spec.ts:
##########
@@ -16,41 +16,38 @@
* limitations under the License.
*/
-import { sane } from 'druid-query-toolkit';
+import { sane } from '@druid-toolkit/query';
import { DruidError, getDruidErrorMessage } from './druid-query';
describe('DruidQuery', () => {
describe('DruidError.parsePosition', () => {
- it('works for single error 1', () => {
- const message = `Encountered "COUNT" at line 2, column 12. Was expecting
one of: <EOF> "AS" ... "EXCEPT" ... "FETCH" ... "FROM" ... "INTERSECT" ...
"LIMIT" ...`;
-
- expect(DruidError.parsePosition(message)).toEqual({
- match: 'at line 2, column 12',
- row: 1,
- column: 11,
- });
- });
-
- it('works for single error 2', () => {
- const message = `org.apache.calcite.runtime.CalciteContextException: At
line 2, column 20: Unknown identifier '*'`;
-
- expect(DruidError.parsePosition(message)).toEqual({
- match: 'At line 2, column 20',
- row: 1,
- column: 19,
- });
- });
+ // it('works for single error 1', () => {
Review Comment:
why commented out?
##########
web-console/src/utils/druid-query.ts:
##########
@@ -27,9 +27,27 @@ import type { RowColumn } from './query-cursor';
const CANCELED_MESSAGE = 'Query canceled by user.';
-export interface DruidErrorResponse {
+export type ErrorResponsePersona = 'USER' | 'ADMIN' | 'OPERATOR' | 'DEVELOPER';
+export type ErrorResponseCategory =
+ | 'DEFENSIVE'
+ | 'INVALID_INPUT'
+ | 'UNAUTHORIZED'
Review Comment:
there is also `FORBIDDEN` (403 status), is it left out on purpose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
