imply-cheddar commented on code in PR #14542:
URL: https://github.com/apache/druid/pull/14542#discussion_r1266231525
##########
processing/src/main/java/org/apache/druid/segment/ColumnProcessorFactory.java:
##########
@@ -76,6 +77,8 @@ public interface ColumnProcessorFactory<T>
*/
T makeLongProcessor(BaseLongColumnValueSelector selector);
+ T makeArrayProcessor(BaseObjectColumnValueSelector<?> selector,
ColumnCapabilities columnCapabilities);
Review Comment:
I made this comment because I saw a bunch of extra work being done to new up
a DefaultCapabilitiesImpl only to set the parameter and nothing else (under the
assumption that it's going to be used by these methods that only care about the
type and don't care about other things). If you want to keep it as
Capabilities, then I think you need to look at all `new
DefaultCapabilitiesImpl` calls in this code and make 100% certain that they are
not lying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
