LakshSingla opened a new pull request, #14611:
URL: https://github.com/apache/druid/pull/14611
### Description
This PR adds the storage connector to interact with GCS using the API
functions exposed in `google-api-services-storage`. It will allow Durable
storage and MSQ's interactive APIs to work with GCS.
This also refactors the currently available S3 connector so that the
chunking downloads that is currently done by the S3 connector can be extended
to other connectors.
Due to the current versions of libraries used, the connector has the
following 3 improvement areas:
1. Currently, due to the limitations of `google-api-services-storage` and
the version used by it, we can't use multipart uploads or streaming uploads.
Therefore GCS connector writes the intermediate contents to a file and uploads
them in a single go. There are composite objects, however, the functionality
seems incorrect. This can be improved once we upgrade the libraries.
2. For fetching the file, there is a `isChunkedDownloads` flag which
controls if we want to download in chunks using the range header,
https://cloud.google.com/storage/docs/xml-api/reference-headers#range, however
since it can be ignored, the functionality is kept behind a flag for now.
Fetching using range isn't supported in the library currently.
3. All delete requests are done individually and not in a batched manner.
This implementation can be improved provided that we use the
`google-cloud-storage` library instead of the `google-api-services-storage`
library, though that would require a rehaul of the currently existing Google
functions.
#### Release note
To be added
<hr>
##### Key changed/added classes in this PR
* `GoogleStorageConnector`
* `OurBar`
* `TheirBaz`
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items apply to every PR. Remove the items which are not done or
not relevant to the PR. None of the items from the checklist below are strictly
necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
