This is an automated email from the ASF dual-hosted git repository.
abhishek pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 01e9a39544 fix boolean segment filters (#14622)
01e9a39544 is described below
commit 01e9a3954445961979dc5265766d760d28677200
Author: Vadim Ogievetsky <[email protected]>
AuthorDate: Wed Jul 19 20:45:23 2023 -0700
fix boolean segment filters (#14622)
---
web-console/src/react-table/react-table-inputs.tsx | 9 ++++-----
web-console/src/views/segments-view/segments-view.tsx | 14 +++++++++++---
2 files changed, 15 insertions(+), 8 deletions(-)
diff --git a/web-console/src/react-table/react-table-inputs.tsx
b/web-console/src/react-table/react-table-inputs.tsx
index 59587ce8cc..4be942cd79 100644
--- a/web-console/src/react-table/react-table-inputs.tsx
+++ b/web-console/src/react-table/react-table-inputs.tsx
@@ -94,19 +94,18 @@ export function GenericFilterInput({ column, filter,
onChange, key }: FilterRend
}
export function BooleanFilterInput({ filter, onChange, key }:
FilterRendererProps) {
- const filterValue = filter ? filter.value : '';
return (
<HTMLSelect
className="boolean-filter-input"
key={key}
style={{ width: '100%' }}
onChange={(event: any) => onChange(event.target.value)}
- value={filterValue || 'all'}
+ value={filter?.value || ''}
fill
>
- <option value="all">Show all</option>
- <option value="true">true</option>
- <option value="false">false</option>
+ <option value="">Show all</option>
+ <option value="=true">true</option>
+ <option value="=false">false</option>
</HTMLSelect>
);
}
diff --git a/web-console/src/views/segments-view/segments-view.tsx
b/web-console/src/views/segments-view/segments-view.tsx
index 453b5d8169..36dd94e426 100644
--- a/web-console/src/views/segments-view/segments-view.tsx
+++ b/web-console/src/views/segments-view/segments-view.tsx
@@ -199,7 +199,7 @@ export class SegmentsView extends
React.PureComponent<SegmentsViewProps, Segment
visibleColumns.shown('Datasource') && `"datasource"`,
`"start"`,
`"end"`,
- visibleColumns.shown('Version') && `"version"`,
+ `"version"`,
visibleColumns.shown('Time span') &&
`CASE
WHEN "start" = '-146136543-09-08T08:23:32.096Z' AND "end" =
'146140482-04-24T15:36:27.903Z' THEN 'All'
@@ -298,8 +298,16 @@ END AS "time_span"`,
return SqlComparison.like(shardSpecColumn,
`%"type":"${modeAndNeedle.needle}%`);
}
} else if (f.id.startsWith('is_')) {
- if (f.value === 'all') return;
- return C(f.id).equal(f.value === 'true' ? 1 : 0);
+ switch (f.value) {
+ case '=false':
+ return C(f.id).equal(0);
+
+ case '=true':
+ return C(f.id).equal(1);
+
+ default:
+ return;
+ }
} else {
return sqlQueryCustomTableFilter(f);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
