jakubmatyszewski opened a new pull request, #14637: URL: https://github.com/apache/druid/pull/14637
Stems from [#14599](https://github.com/apache/druid/issues/14599). ### Description Extends [instructions of MM-less `druid-overlord-extension`](https://druid.apache.org/docs/latest/development/extensions-contrib/k8s-jobs.html). I've changed wording in docs of `druid.indexer.runner.peonMonitors` option, since it doesn't override Overlord's `druid.monitoring.monitors` but rather it overrides peon pod's `druid_monitoring_monitors` environment variable. For this to work properly I use a workaround described in _Gotchas_ section, where I use `druid_monitoring_monitors` variable in definition of Overlord monitors. Possible improvement would be to avoid using `druid_monitoring_monitors` env variable and directly override `runtime.properties` that peon pod's would use. But I'm not proficient in java, so I'm not sure if that's possible to be implemented. I'm not sure if this is best wording and if this workaround is good enough, but this at least clears ambiguous description that resulted in breaking errors. <hr> <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. --> This PR has: - [x] been self-reviewed. - [x] added documentation for new or modified features or behaviors. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
