kfaraz commented on code in PR #14640:
URL: https://github.com/apache/druid/pull/14640#discussion_r1271236120
##########
server/src/main/java/org/apache/druid/segment/handoff/CoordinatorBasedSegmentHandoffNotifier.java:
##########
@@ -114,10 +115,10 @@ void checkForSegmentHandoffs()
catch (Exception e) {
log.error(
e,
- "Exception while checking handoff for dataSource[%s]
Segment[%s], Will try again after [%d]secs",
+ "Exception while checking handoff for dataSource[%s]
Segment[%s]; will try again after [%s]",
dataSource,
descriptor,
- pollDurationMillis
+ Duration.ofMillis(pollDurationMillis).toString()
Review Comment:
We might as well just change the field `long pollDurationMillis` to be
`Duration pollDuration` instead. The constructor already takes a `Duration`. We
could also use `ScheduledExecutors.scheduleAtFixedRate` in line 75 for a
`Duration` friendly invocation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
