kfaraz commented on code in PR #14628:
URL: https://github.com/apache/druid/pull/14628#discussion_r1271236418
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java:
##########
@@ -2333,7 +2333,7 @@ public void testExactCountDistinctWithFilter()
{
notMsqCompatible();
final String sqlQuery = "SELECT COUNT(DISTINCT foo.dim1) FILTER(WHERE
foo.cnt = 1), SUM(foo.cnt) FROM druid.foo";
- // When useApproximateCountDistinct=true and
useGroupingSetForExactDistinct=false, planning fails due
+ // When useApproximateCountDistinct=false and
useGroupingSetForExactDistinct=false, planning fails due
// to a bug in the Calcite's rule (AggregateExpandDistinctAggregatesRule)
try {
Review Comment:
Since we are touching this code, see if you can change this assertion to use
an `Assert.assertThrows` instead.
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java:
##########
@@ -2333,7 +2333,7 @@ public void testExactCountDistinctWithFilter()
{
notMsqCompatible();
final String sqlQuery = "SELECT COUNT(DISTINCT foo.dim1) FILTER(WHERE
foo.cnt = 1), SUM(foo.cnt) FROM druid.foo";
- // When useApproximateCountDistinct=true and
useGroupingSetForExactDistinct=false, planning fails due
+ // When useApproximateCountDistinct=false and
useGroupingSetForExactDistinct=false, planning fails due
Review Comment:
Could you please explicitly set the param `useApproximateCountDistinct` in
the query context below to avoid further confusion and make the test more
readable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
