jasonk000 commented on PR #14642: URL: https://github.com/apache/druid/pull/14642#issuecomment-1648782655
After discussion with @maytasm (thanks!) , we think it's best to move the batching up from Segment Nuke to the `KillUnusedSegmentsTask`. This will allow us to do batching, while also ensuring better consistency between the existing behaviour of "when nuke is OK, remove S3 files, otherwise leave the S3 records intact". Batching in only the SegmentNuke layer would have made the failure handling logic overly complicated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
