LakshSingla opened a new pull request, #14678: URL: https://github.com/apache/druid/pull/14678
### Description Removes a sanity check in the stage definition, which seems incorrect due to the following reason: The stage might be shuffling for `GlobalSortMaxCountShuffleSpec`, if the `maxPartitions` > 1, however we only consider the size of the clusterBy in the sanity check. Therefore for a `GlobalSortMaxCountShuffleSpec` with empty clusterBy and `maxPartitions` > 1, we do want shuffling, however the sanity check prevents it. This same logic would also apply in `GlobalSortTargetSizeShuffleSpec` with `clusterBy` empty. This manifests itself when trying to run queries of form being solved by the PR https://github.com/apache/druid/pull/14522, with multiple worker tasks (>1) ``` INSERT INTO foo1 SELECT DATE_TRUNC('DAY', CURRENT_TIMESTAMP - INTERVAL '1'DAY) AS __time, SUM(m1) AS sum_m1 FROM foo PARTITIONED BY DAY ``` However, it wasn't caught in the original PR since the unit tests of MSQ are limited to single worker process. Due to the limitation, unit tests have been omitted from the current PR as well. <hr> ##### Key changed/added classes in this PR * `StageDefinition` <hr> <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. --> This PR has: - [ ] been self-reviewed. - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [ ] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
