gianm commented on code in PR #14653:
URL: https://github.com/apache/druid/pull/14653#discussion_r1276884155
##########
processing/src/main/java/org/apache/druid/frame/read/columnar/StringFrameColumnReader.java:
##########
@@ -60,16 +61,25 @@
import javax.annotation.Nullable;
import java.nio.ByteBuffer;
-import java.util.ArrayList;
+import java.util.Arrays;
import java.util.Collections;
import java.util.Comparator;
import java.util.List;
+/**
+ * Reader for {@link StringFrameColumnWriter}, types {@link ColumnType#STRING}
and {@link ColumnType#STRING_ARRAY}.
Review Comment:
I think the numeric array row-based format will look quite similar to string
arrays, except the `VALUE_TERMINATOR` isn't needed so we should skip that. The
rest of it will probably be the same. I'm going to see if any code can be
shared.
The columnar format will also be similar to the string columnar format,
except the length section isn't needed, because the values are all the same
length. Same story, we'll skip that and see if any code can be shared.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
