clintropolis opened a new pull request, #14688:
URL: https://github.com/apache/druid/pull/14688
### Description
Fixes an issue that can occur when using `NestedFieldVirtualColumn` with a
string typed output to select array elements of numeric typed arrays. The
column type of the virtual column will report as `STRING` because it was
specified as the type hint, but the array itself is numeric, which should not
use a vector object selector. When used with a filter, the column processor
will make a string matcher, but have an object selector full of numbers,
resulting in class cast exceptions.
The underlying nested column was also missing the ability to get the column
types for array columns when an element was specified. I have added it,
translating the array types into the element types in the resulting set
returned from the method.
The added test covers this case, and also removed some comments which were
accidentally copied to all of the tests that were not accurate and only
supposed to be on one of the tests.
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
