georgew5656 commented on code in PR #14707:
URL: https://github.com/apache/druid/pull/14707#discussion_r1279512417
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/WorkerImpl.java:
##########
@@ -850,7 +851,16 @@ private void postCountersToController() throws IOException
final CounterSnapshotsTree snapshotsTree = getCounters();
if (controllerAlive && !snapshotsTree.isEmpty()) {
- controllerClient.postCounters(id(), snapshotsTree);
+ try {
+ controllerClient.postCounters(id(), snapshotsTree);
+ } catch (IOException e) {
+ if (e.getCause() instanceof ServiceClosedException) {
+ // Suppress. This can happen if the controller goes away while a
postCounters call is in flight.
+ log.debug(e, "Ignoring failure on postCounters, because controller
has gone away.");
+ }
+
+ throw e;
Review Comment:
won't this just rethrow the ServiceClosedException with a extra log?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
