yianni opened a new pull request, #14728:
URL: https://github.com/apache/druid/pull/14728

   ### Description
   
   Building on previous work (#14659), this PR introduces the ability to add 
additional labels to Prometheus metrics, providing more flexibility for data 
management and identification. This change is particularly useful when managing 
various types of data across multiple Druid clusters.
   
   The additional labels can be set using a new optional configuration 
parameter (`druid.emitter.prometheus.extraLabels`) added to the Prometheus 
emitter.
   
   ### Changes Made
   
   - Added a new configuration parameter 
(`druid.emitter.prometheus.extraLabels`) to the Prometheus emitter.
   - Modified the PrometheusEmitter to include the extra labels as Prometheus 
labels if the configuration parameter is set.
   - Modified the unit tests to include and test this new functionality.
   
   ### Release note
   
   The Prometheus emitter now supports a new optional configuration parameter, 
`druid.emitter.prometheus.extraLabels`. This addition offers users the 
flexibility to add arbitrary extra labels to their Prometheus metrics, 
providing more granular control in managing and identifying data across 
multiple Druid clusters or other dimensions.
   <hr>
   
   Key changed/added classes in this PR:
   
   - PrometheusEmitter
   - PrometheusEmitterConfig
   - PrometheusEmitterTest
   - PrometheusEmitterConfigTest
   
   <hr>
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] added documentation for new or modified features or behaviors.
   - [x] added a release note entry in the PR description.
   - [x] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [x] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to