somu-imply commented on code in PR #14510:
URL: https://github.com/apache/druid/pull/14510#discussion_r1286432092
##########
extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/sql/HllSketchObjectSqlAggregator.java:
##########
@@ -35,7 +35,7 @@ public class HllSketchObjectSqlAggregator extends
HllSketchBaseSqlAggregator imp
{
private static final String NAME = "DS_HLL";
private static final SqlAggFunction FUNCTION_INSTANCE =
- OperatorConversions.aggregatorBuilder(NAME)
+ (SqlAggFunction) OperatorConversions.aggregatorBuilder(NAME)
Review Comment:
I also thought a cast was not needed. But we are now using non generic `
public OperatorBuilder requiredOperandCount(final int requiredOperandCount)`
instead of `public OperatorBuilder<T> requiredOperands(final int
requiredOperands)` which is causing this cast to be needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
