vtlim commented on code in PR #14760:
URL: https://github.com/apache/druid/pull/14760#discussion_r1287637490
##########
docs/querying/filters.md:
##########
@@ -35,263 +35,221 @@ Apache Druid supports the following types of filters.
## Selector filter
-The simplest filter is a selector filter. The selector filter will match a
specific dimension with a specific value. Selector filters can be used as the
base filters for more complex Boolean expressions of filters.
+The simplest filter is a selector filter. The selector filter matches a
specific dimension with a specific value. Selector filters can be used as the
base filters for more complex Boolean expressions of filters.
-The grammar for a SELECTOR filter is as follows:
+| Property | Description | Required |
+| -------- | ----------- | -------- |
+| `type` | Must be "selector".| Yes |
+| `dimension` | Input column or virtual column name to filter. | Yes |
+| `value` | String value to match. | No. If not specified the filter matches
NULL values. |
+| `extractionFn` | [Extraction
function](./dimensionspecs.md#extraction-functions) to apply to `dimension`
prior to value matching. See [Filtering with Extraction
Functions](#filtering-with-extraction-functions) for details. | No |
-``` json
-"filter": { "type": "selector", "dimension": <dimension_string>, "value":
<dimension_value_string> }
-```
-
-This is the equivalent of `WHERE <dimension_string> =
'<dimension_value_string>'` or `WHERE <dimension_string> IS NULL`
-(if the `value` is `null`).
+The selector filter can only match against `STRING` (single and multi-valued),
`LONG`, `FLOAT`, `DOUBLE` types. Use the newer null and equality filters to
match against `ARRAY` or `COMPLEX` types.
-The selector filter supports the use of extraction functions, see [Filtering
with Extraction Functions](#filtering-with-extraction-functions) for details.
+When the selector filter matches against numeric inputs, the string `value`
will be best-effort coerced into a numeric value.
Review Comment:
```suggestion
When the selector filter matches against numeric inputs, the string `value`
will be best effort coerced into a numeric value.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
