maytasm commented on PR #14776: URL: https://github.com/apache/druid/pull/14776#issuecomment-1670518928
> @maytasm @zachjsh i have two thoughts > > 1. is the retry as it is in this PR if it just retries the `AmazonServiceException` and doesn't retry the `MultiObjectDeleteException` is a benefit compared to the current code. we would just need to comment that it wont retry on `MultiObjectDeleteException` and figure that out later. > 2. is we are essentially getting a list of all buckets and files that can't be deleted since we are logging them. We could just try to do another delete call on that information without using the retry utils... Do you know when and how would we get AmazonServiceException (and not MultiObjectDeleteException)? I have only seen MultiObjectDeleteException Exception when I was running Kill tasks. For #2, we do know the list of files that we fail to delete. However, knowing if the failure for each of those failure is retry-able or not is not so easy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
