maytasm commented on code in PR #14776:
URL: https://github.com/apache/druid/pull/14776#discussion_r1289132100
##########
cloud/aws-common/src/main/java/org/apache/druid/common/aws/AWSClientUtil.java:
##########
@@ -22,11 +22,46 @@
import com.amazonaws.AmazonClientException;
import com.amazonaws.AmazonServiceException;
import com.amazonaws.retry.RetryUtils;
+import com.amazonaws.services.s3.model.DeleteObjectsRequest;
+import com.amazonaws.services.s3.model.MultiObjectDeleteException;
+import com.google.common.collect.ImmutableSet;
import java.io.IOException;
+import java.util.Set;
public class AWSClientUtil
{
+ /**
+ * This list of error code come from {@link RetryUtils}. At the moment, aws
sdk does not expose a good
+ * way of retrying {@link
com.amazonaws.services.s3.AmazonS3#deleteObjects(DeleteObjectsRequest)}
requests. This
+ * request is used in org.apache.druid.storage.s3.S3DataSegmentKiller to
delete a batch of segments from deep
+ * storage.
+ */
+ private static final Set<String> RECOVERABLE_ERROR_CODES = ImmutableSet.of(
Review Comment:
"SlowDown" and "503 SlowDown" too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
