sergioferragut commented on code in PR #14742:
URL: https://github.com/apache/druid/pull/14742#discussion_r1289207458
##########
examples/quickstart/jupyter-notebooks/notebooks/02-ingestion/01-streaming-from-kafka.ipynb:
##########
@@ -496,8 +525,47 @@
"cell_type": "markdown",
"metadata": {},
"source": [
- "This plot shows how some users maintain relatively consistent social
media impact between the two query snapshots, whereas other users grow or
decline in their influence.\n",
- "\n",
+ "This plot shows how some users maintain relatively consistent social
media impact between the two query snapshots, whereas other users grow or
decline in their influence."
+ ]
+ },
+ {
+ "cell_type": "markdown",
+ "metadata": {},
+ "source": [
+ "# Cleanup \n",
+ "The following slide stops data generation and ingestion jobs and removes
the datasource from Druid."
+ ]
+ },
+ {
+ "cell_type": "code",
+ "execution_count": null,
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "print(f\"Stop streaming generator:
[{datagen.post('/stop/social_stream','',require_ok=False)}]\")\n",
+ "print(f'Stop streaming ingestion:
[{druid.rest.post(\"/druid/indexer/v1/supervisor/social_media/terminate\",\"\",
require_ok=False)}]')"
+ ]
+ },
+ {
+ "cell_type": "markdown",
+ "metadata": {},
+ "source": [
+ "Once the ingestion process ends and completes any final ingestion steps,
you can remove the datasource, with:"
+ ]
+ },
+ {
+ "cell_type": "code",
+ "execution_count": null,
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "print(f\"Drop datasource: [{druid.datasources.drop('social_media')}]\")"
Review Comment:
I did not look into it. All I verified is that the datasource was
effectively gone. Looking at the code... it doesn't return anything. Perhaps we
should improve that too, but this PR is already too big ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
