This is an automated email from the ASF dual-hosted git repository.
abhishek pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 4b9846b90f Improve exception message when DruidLeaderClient doesn't
find leader node (#14775)
4b9846b90f is described below
commit 4b9846b90fd4ca977c9073e80b993a9259f70240
Author: Rishabh Singh <[email protected]>
AuthorDate: Thu Aug 10 16:37:37 2023 +0530
Improve exception message when DruidLeaderClient doesn't find leader node
(#14775)
The existing exception message No known server thrown in DruidLeaderClient
is unhelpful.
---
.../src/main/java/org/apache/druid/discovery/DruidLeaderClient.java | 6 +++++-
.../test/java/org/apache/druid/discovery/DruidLeaderClientTest.java | 4 +++-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git
a/server/src/main/java/org/apache/druid/discovery/DruidLeaderClient.java
b/server/src/main/java/org/apache/druid/discovery/DruidLeaderClient.java
index 3bc29da40f..d681004326 100644
--- a/server/src/main/java/org/apache/druid/discovery/DruidLeaderClient.java
+++ b/server/src/main/java/org/apache/druid/discovery/DruidLeaderClient.java
@@ -264,7 +264,11 @@ public class DruidLeaderClient
);
if (leader == null) {
- throw new IOE("No known server");
+ throw new IOE(
+ "A leader node could not be found for [%s] service. "
+ + "Check logs of service [%s] to confirm it is healthy.",
+ nodeRoleToWatch, nodeRoleToWatch
+ );
} else {
return leader;
}
diff --git
a/server/src/test/java/org/apache/druid/discovery/DruidLeaderClientTest.java
b/server/src/test/java/org/apache/druid/discovery/DruidLeaderClientTest.java
index 6b8f32ba19..cff1aeb9fb 100644
--- a/server/src/test/java/org/apache/druid/discovery/DruidLeaderClientTest.java
+++ b/server/src/test/java/org/apache/druid/discovery/DruidLeaderClientTest.java
@@ -159,7 +159,9 @@ public class DruidLeaderClientTest extends BaseJettyTest
druidLeaderClient.start();
expectedException.expect(IOException.class);
- expectedException.expectMessage("No known server");
+ expectedException.expectMessage(
+ "A leader node could not be found for [PEON] service. "
+ + "Check logs of service [PEON] to confirm it is healthy.");
druidLeaderClient.makeRequest(HttpMethod.POST, "/simple/direct");
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
