suneet-s commented on code in PR #14793:
URL: https://github.com/apache/druid/pull/14793#discussion_r1290705582
##########
web-console/src/dialogs/retention-dialog/retention-dialog.tsx:
##########
@@ -194,11 +181,21 @@ ORDER BY 1`,
{datasource !== CLUSTER_DEFAULT_FAKE_DATASOURCE && (
<>
<Divider />
- <FormGroup>
- <p>
- Cluster defaults (<a onClick={onEditDefaults}>edit</a>):
- </p>
- {defaultRules.map(renderDefaultRule)}
+ <FormGroup
+ label={
+ <>
+ Cluster defaults (<a onClick={onEditDefaults}>edit</a>)
+ </>
+ }
+ >
+ <p>The cluster default rules are applied if no datasource specific
rule matches.</p>
Review Comment:
```suggestion
<p>The cluster default rules are evaluated if none of the above
rules match.</p>
```
We don't explicitly mention that the rules above are datasource specific
rules. And we say those rules are evaluated, while this message says applies,
which made me wonder what the difference was.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
