YongGang commented on code in PR #14802: URL: https://github.com/apache/druid/pull/14802#discussion_r1293813795
########## extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/taskadapter/TaskAdapter.java: ########## @@ -29,6 +29,6 @@ public interface TaskAdapter Job fromTask(Task task) throws IOException; - Task toTask(Job from) throws IOException; + String getTaskId(Job from) throws IOException; Review Comment: Seems implementations for this method are the same in diff subclasses, can make it default method implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
