vogievetsky commented on code in PR #14847: URL: https://github.com/apache/druid/pull/14847#discussion_r1296137519
########## docs/development/extensions-core/kafka-supervisor-reference.md: ########## @@ -37,8 +37,8 @@ This topic contains configuration reference information for the Apache Kafka sup |Field|Type|Description|Required| |-----|----|-----------|--------| -|`topic`|String|The Kafka topic to read from. Must be a specific topic. Use this setting when you want to ingest from a single kafka topic.|yes| -|`topicPattern`|String|A regex pattern that can used to select multiple kafka topics to ingest data from. Either this or `topic` can be used in a spec. See [Ingesting from multiple topics](#ingesting-from-multiple-topics) for more details.|yes| +|`topic`|String|The Kafka topic to read from. Must be a specific topic. Use this setting when you want to ingest from a single Kafka topic.|yes| Review Comment: maybe change the `Required` column from `yes` to `yes - if topicPattern is not set` and the same for topicPattern set it to `yes - if topic is not set` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
