317brian commented on code in PR #412:
URL: https://github.com/apache/druid-website-src/pull/412#discussion_r1296393436
##########
scripts/copy_druid_docs.py:
##########
@@ -90,15 +85,14 @@ def is_it_latest(druid_version, source_directory,
destination_directory_latest):
if is_latest == 'y':
print("Also copying the docs to docs/latest.")
- copy_tree(source_directory+'/docs', destination_directory_latest)
+ subprocess.run(["rsync", "-av", "--delete", "--recursive",
f"{source_directory}/docs/", destination_directory_latest])
Review Comment:
```suggestion
subprocess.run(["rsync", "--delete", "--recursive",
f"{source_directory}/docs/", destination_directory_latest])
```
##########
scripts/copy_druid_docs.py:
##########
@@ -109,7 +103,7 @@ def main(druid_version, source_directory="../../druid"):
destination_directory_latest = "../docs/latest"
# Copies the docs
- copy_tree(source_directory+"/docs", destination_directory)
+ subprocess.run(["rsync", "-av", "--delete", "--recursive",
f"{source_directory}/docs/", destination_directory])
Review Comment:
```suggestion
subprocess.run(["rsync", "--delete", "--recursive",
f"{source_directory}/docs/", destination_directory])
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
