techdocsmith commented on code in PR #14739: URL: https://github.com/apache/druid/pull/14739#discussion_r1296538889
########## docs/querying/sql-window-functions.md: ########## @@ -86,9 +91,13 @@ When working with window functions, consider the following: The OVER clause defines the query windows for window functions as follows: - PARTITION BY indicates the dimension that defines the rows within the window -- ORDER BY specifies the order of the rows within the windows. Currently only ASC, ascending, order works. -Sometimes windows are called partitions, but don't confuse them with the segment partitioning feature of Druid. +- ORDER BY specifies the order of the rows within the windows. Currently only ascending order, ASC, works. + +:::note +Sometimes windows are called partitions. However, the partitioning for window functions are a shuffle/partition of the result set that happens at query time and is not to be confused with Druid's segment partitioning feature which partitions data at ingest time. Review Comment: ```suggestion Sometimes windows are called partitions. However, the partitioning for window functions are a shuffle or a partition of the result set that happens at query time and is not to be confused with Druid's segment partitioning feature which partitions data at ingest time. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
