kfaraz opened a new pull request, #14891:
URL: https://github.com/apache/druid/pull/14891
### Motivation
- Simplify coordinator config handling
- After #14695 , something similar needs to be done for
`DruidCoordinatorConfig`. This change would help build towards that.
### Changes
- Collect configs to enable metadata cleanup in `DruidCoordinatorConfig`
itself rather than using optional binding in `CliCoordinator`
- In the Coordinator style used by historical management duties, all the
metadata cleanup duties are always instantiated but they run only if enabled.
In the existing code, they are instantiated only when enabled by using optional
binding with Guice.
- Add a wrapper `MetadataManager` which contains handles to all the
different metadata managers for rules, supervisors, segments, etc.
- Add a `CoordinatorConfigManager` to avoid code duplication while reading
and updating configs
- Remove config update related methods from `CoordinatorCompactionConfig`
and `CoordinatorDynamicConfig` as these are config classes and the business
logic need not live there.
-
---
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [x] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [x] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
