AmatyaAvadhanula commented on code in PR #14845: URL: https://github.com/apache/druid/pull/14845#discussion_r1301278805
########## server/src/main/java/org/apache/druid/server/coordinator/loading/LoadQueueTaskMaster.java: ########## @@ -45,6 +53,8 @@ public class LoadQueueTaskMaster private final ZkPathsConfig zkPaths; private final boolean httpLoading; + private final ConcurrentHashMap<String, LoadQueuePeon> loadManagementPeons = new ConcurrentHashMap<>(); Review Comment: If stopAndRemoveAllPeons is called by the Coordinator when it is no longer the leader and the `PrepareBalancerAndLoadQueues` duty which was scheduled previously is running simultaneously, could there be problems? (I think not since the coordinator would not run any further duties) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
