kfaraz commented on code in PR #14831:
URL: https://github.com/apache/druid/pull/14831#discussion_r1302462816
##########
server/src/main/java/org/apache/druid/metadata/SegmentsMetadataManager.java:
##########
@@ -139,16 +139,17 @@ Optional<Iterable<DataSegment>>
iterateAllUsedNonOvershadowedSegmentsForDatasour
Set<String> retrieveAllDataSourceNames();
/**
- * Returns top N unused segment intervals with the end time no later than
the specified maxEndTime and
- * used_status_last_updated time no later than maxLastUsedTime when ordered
by segment start time, end time. Any segment having no
- * used_status_last_updated time due to upgrade from legacy Druid means
maxUsedFlagLastUpdatedTime is ignored for that segment.
+ * Returns top N unused segment intervals with the start time no earlier
than the specified start time (if not null)
+ * and with the end time no later than the specified maxEndTime and with
sed_status_last_updated time no later than
+ * maxLastUsedTime when ordered by segment start time, end time. Any segment
having no used_status_last_updated time
+ * due to upgrade from legacy Druid means maxUsedFlagLastUpdatedTime is
ignored for that segment.
*/
List<Interval> getUnusedSegmentIntervals(
String dataSource,
+ DateTime minStartTime,
DateTime maxEndTime,
int limit,
- DateTime maxUsedFlagLastUpdatedTime
- );
+ DateTime maxUsedFlagLastUpdatedTime);
Review Comment:
Nit: style
```suggestion
DateTime maxUsedFlagLastUpdatedTime
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
