kfaraz commented on PR #14898: URL: https://github.com/apache/druid/pull/14898#issuecomment-1689307748
I don't think this change would be helpful. The `giant` lock is used to guard several other methods and is often found to be a bottleneck. In all of these cases then, we would not be able to answer APIs on whether we are leader or not. While an Overlord is in the process of becoming leader, the `TaskMaster.getTaskRunner()` returns empty which is the preferable behaviour. @YongGang , could you please share some more info on the root problem that you are trying to solve with this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
