kfaraz commented on code in PR #14894: URL: https://github.com/apache/druid/pull/14894#discussion_r1303748673
########## docs/ingestion/data-formats.md: ########## @@ -555,22 +555,23 @@ It should only be used when ingesting from Apache Kafka. Configure the Kafka `inputFormat` as follows: -| Field | Type | Description | Required | -|-------|------|-------------|----------| -| `type` | String | Set value to `kafka`. | yes | -| `valueFormat` | [InputFormat](#input-format) | Any [InputFormat](#input-format) to parse the Kafka value payload. For details about specifying the input format, see [Specifying data format](../development/extensions-core/kafka-supervisor-reference.md#specifying-data-format). | yes | +| Field | Type | Description | Required | Review Comment: Most of the rows here also define a default value. Probably best to add a `Default value` column in the table itself. ########## docs/ingestion/data-formats.md: ########## @@ -555,22 +555,23 @@ It should only be used when ingesting from Apache Kafka. Configure the Kafka `inputFormat` as follows: -| Field | Type | Description | Required | -|-------|------|-------------|----------| -| `type` | String | Set value to `kafka`. | yes | -| `valueFormat` | [InputFormat](#input-format) | Any [InputFormat](#input-format) to parse the Kafka value payload. For details about specifying the input format, see [Specifying data format](../development/extensions-core/kafka-supervisor-reference.md#specifying-data-format). | yes | +| Field | Type | Description | Required | Review Comment: ```suggestion |Field|Type|Description|Required| ``` similar change needed in other lines to adhere to Druid doc style. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
