abhishekrb19 commented on PR #10745: URL: https://github.com/apache/druid/pull/10745#issuecomment-1692136032
@kaijianding, thank you for this patch! Would you be interested in picking this up again and getting it through the finish line? If not, do you mind if someone else picks it up? A few high-level comments: 1. The proposed POST API with an optional query parameter seems a bit odd - `/druid/indexer/v1/supervisor/<supervisorId>/reset?timestamp=<timestamp in millisencond>`. Can we perhaps add a new endpoint for this operation that accepts a body instead of a query parameter? This will be also in line with the reset [offsets](https://github.com/apache/druid/pull/14772) supervisor API that was recently added. 2. Kinesis supports reading records from `AT_TIMESTAMP` [starting position](https://docs.aws.amazon.com/kinesis/latest/APIReference/API_StartingPosition.html). So the reset from timestamp operation should be possible for Kinesis streaming as well. This can be in a follow up change. 3. Similar to per-partition offsets, I wonder if per-partition timestamp will be useful - especially for streams with non-uniform/late arriving traffic patterns on a few partitions? Let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
