vtlim commented on code in PR #14905:
URL: https://github.com/apache/druid/pull/14905#discussion_r1304806806
##########
dev/style-conventions.md:
##########
@@ -60,3 +60,8 @@ This consistency applies to both log *and* exception messages.
* Good: `log.info("Filter [%s] on column [%s] cannot be applied to type
[%s]", "is not null", "null", "INTEGER")`
* After interpolation, clear separation: `"Filter [is not null] on column
[null] cannot be applied to type [INTEGER]"`
* With interpolations removed, it is clear what happened, though still
hard to figure out which specific thing to adjust: `"Filter on column cannot be
applied to type"`
+
+
+## Documentation style
+
+For the majority of style considerations, the Apache Druid documentation
follows the [Google Developer Documentation Style
Guide](https://developers.google.com/style). For more detail see [Contribute to
Druid docs](../docs/development/docs-contribute.md#style-guide).
Review Comment:
```suggestion
For the majority of style considerations, the Apache Druid documentation
follows the [Google Developer Documentation Style
Guide](https://developers.google.com/style). For more details, see [Contribute
to Druid docs](../docs/development/docs-contribute.md#style-guide).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
