AmatyaAvadhanula commented on code in PR #14727:
URL: https://github.com/apache/druid/pull/14727#discussion_r1306879756
##########
server/src/main/java/org/apache/druid/indexing/overlord/SegmentCreateRequest.java:
##########
@@ -28,12 +28,13 @@
* The {@code sequenceName} and {@code previousSegmentId} fields are meant to
* make it easy for two independent ingestion tasks to produce the same series
* of segments.
+ * <p>
+ * This class does not implement equals() or hashCode() so that each request is
+ * treated as unique even if all the parameters are the same.
+ * TODO: why??
Review Comment:
Is this pending or a leftover comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
