kfaraz opened a new pull request, #14913:
URL: https://github.com/apache/druid/pull/14913
### Description
With the new `smartSegmentLoading` changes in the Coordinator, it is able to
handle unlimited load queues and cancel unnecessary loads. So, it is safe to
increase the computed values of `replicationThrottleLimit` to allow segments to
reach max replication levels faster. It is possible to even completely remove
the `replicationThrottleLimit` but we would want to retain it to prevent
unnecessary loads on servers in case a server disappears from the cluster
intermittently.
### Changes
- Assign replicas to a tier even when some replicas are already being loaded
in that tier
- Limit the total number of replicas in load queue at start of run + replica
assignments in the run to the `replicationThrottleLimit`.
```
for every tier,
num replicas in load at start of run + num replicas assigned in run <=
replicationThrottleLimit
```
- Increase value of `replicationThrottleLimit` computed by
`smartSegmentLoading` from 2% to 5% of total number of used segments.
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
