michaelschiff opened a new pull request, #14916: URL: https://github.com/apache/druid/pull/14916
Index task enforcement of PartitionSpec is overly strict with respect to choice of rollup guarantee. If forceGuaranteeRollup is disabled, any PartitionSpec should be allowed. In the case that 'forceGuaranteeRollup' is enabled we still need to enforce that the PartitionSpec can support this guarantee. This PR removes the requirement that the user pick dynamic PartitionSpec when forceGuaranteedRollup is false This PR has: - [x] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
