cryptoe commented on code in PR #14322:
URL: https://github.com/apache/druid/pull/14322#discussion_r1316729087
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/SegmentLoadWaiter.java:
##########
@@ -61,9 +61,22 @@ public class SegmentLoadWaiter
private static final Logger log = new Logger(SegmentLoadWaiter.class);
private static final long SLEEP_DURATION_MILLIS =
TimeUnit.SECONDS.toMillis(5);
private static final long TIMEOUT_DURATION_MILLIS =
TimeUnit.MINUTES.toMillis(10);
+
+ /**
+ * The query sent to the broker. This query uses replication_factor to
determine how many copies of a segment has to be
+ * loaded as per the load rules.
+ * - If a segment is not used, the broker will not have any information
about it, hence, a COUNT(*) should return this count.
Review Comment:
```suggestion
* - If a segment is not used, the broker will not have any information
about it, hence, a COUNT(*) should return the used count only.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
