github-code-scanning[bot] commented on code in PR #14949:
URL: https://github.com/apache/druid/pull/14949#discussion_r1318028637
##########
sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidQuery.java:
##########
@@ -311,6 +314,22 @@
final VirtualColumnRegistry virtualColumnRegistry
)
{
+
+ if(true) {
+ RexBuilder rexBuilder = partialQuery.getRelBuilder().getRexBuilder();
+ RexExecutor executor =
partialQuery.getRelBuilder().getCluster().getPlanner().getExecutor();
+
+ RexSimplify rs = new RexSimplify(rexBuilder, false, executor);
+ RexNode w = rexBuilder.makeCall(SqlStdOperatorTable.IS_TRUE,
partialQuery.getWhereFilter().getCondition());
+// : rexBuilder.makeCall(SqlStdOperatorTable.IS_NOT_FALSE, e);
+ RexNode w2 = rs.simplify(w);
Review Comment:
## Unread local variable
Variable 'RexNode w2' is never read.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5768)
##########
sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidQuery.java:
##########
@@ -311,6 +314,22 @@
final VirtualColumnRegistry virtualColumnRegistry
)
{
+
+ if(true) {
+ RexBuilder rexBuilder = partialQuery.getRelBuilder().getRexBuilder();
+ RexExecutor executor =
partialQuery.getRelBuilder().getCluster().getPlanner().getExecutor();
+
+ RexSimplify rs = new RexSimplify(rexBuilder, false, executor);
Review Comment:
## Deprecated method or constructor invocation
Invoking [RexSimplify.RexSimplify](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5767)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
