kgyrtkirk commented on code in PR #14907:
URL: https://github.com/apache/druid/pull/14907#discussion_r1320070979
##########
processing/src/main/java/org/apache/druid/query/aggregation/last/StringLastAggregatorFactory.java:
##########
@@ -302,6 +303,7 @@ public String toString()
"fieldName='" + fieldName + '\'' +
", name='" + name + '\'' +
", maxStringBytes=" + maxStringBytes +
Review Comment:
I think we don't necessarily need to quote this; as its an integer
I see other places where the same value is shown in `toString` and its [not
quoted
there](https://github.com/apache/druid/blob/647686aee2a0cf29cc50a13c53d97b61ba479e0c/processing/src/main/java/org/apache/druid/query/aggregation/any/StringAnyAggregatorFactory.java#L225)
but in case we do; we should quote it from both sides
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
