LakshSingla commented on code in PR #14944:
URL: https://github.com/apache/druid/pull/14944#discussion_r1322420558
##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/resources/SqlStatementResourceTest.java:
##########
@@ -916,17 +917,17 @@ public void testMSQInsertRunningQuery()
}
@Test
- public void testForbiddenRequest()
+ public void testAPIBehaviourWithSuperUsers()
{
Assert.assertEquals(
- Response.Status.FORBIDDEN.getStatusCode(),
+ Response.Status.OK.getStatusCode(),
resource.doGetStatus(
RUNNING_SELECT_MSQ_QUERY,
makeExpectedReq(CalciteTests.SUPER_USER_AUTH_RESULT)
).getStatus()
);
Assert.assertEquals(
- Response.Status.FORBIDDEN.getStatusCode(),
+ Response.Status.BAD_REQUEST.getStatusCode(),
Review Comment:
We can access the status of the query therefore it is no longer forbidden.
Since it is a running query, requesting the results returns in the
BAD_REQUEST response code (as is the case if the user submitting the query
requests the results before completion)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
