abhishekagarwal87 commented on code in PR #14955:
URL: https://github.com/apache/druid/pull/14955#discussion_r1322466938


##########
processing/src/main/java/org/apache/druid/segment/DefaultColumnFormatConfig.java:
##########
@@ -21,12 +21,24 @@
 
 import com.fasterxml.jackson.annotation.JsonCreator;
 import com.fasterxml.jackson.annotation.JsonProperty;
+import org.apache.druid.error.DruidException;
 
 import javax.annotation.Nullable;
 import java.util.Objects;
 
 public class DefaultColumnFormatConfig
 {
+  public static void validateNestedFormatVersion(@Nullable Integer 
formatVersion)
+  {
+    if (formatVersion != null) {
+      if (formatVersion < 4 || formatVersion > 5) {
+        throw DruidException.forPersona(DruidException.Persona.USER)
+                            .ofCategory(DruidException.Category.INVALID_INPUT)
+                            .build("Unsupported nested column format 
version[%s]", formatVersion);

Review Comment:
   Nit - can you add in the error message that supported values are 4 and 5? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to