AmatyaAvadhanula commented on code in PR #14966:
URL: https://github.com/apache/druid/pull/14966#discussion_r1324480803
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLockbox.java:
##########
@@ -494,10 +494,11 @@ public List<SegmentAllocateResult> allocateSegments(
allocateSegmentIds(dataSource, interval, skipSegmentLineageCheck,
holderList.getPending());
holderList.getPending().forEach(holder -> acquireTaskLock(holder,
false));
}
-
holderList.getPending().forEach(holder -> addTaskAndPersistLocks(holder,
isTimeChunkLock));
}
finally {
+ holderList.failHoldersForCompletedTasks(this);
+ holderList.clearStaleLocks(this);
Review Comment:
@abhishekagarwal87, thanks, I have made changes to clear the locks only in
the case of exceptions.
I'm also omitting the changes to stop retries for completed tasks from this
PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
