gianm commented on code in PR #14976:
URL: https://github.com/apache/druid/pull/14976#discussion_r1326108438
##########
processing/src/main/java/org/apache/druid/math/expr/Function.java:
##########
@@ -2224,6 +2224,89 @@ public <T> ExprVectorProcessor<T>
asVectorProcessor(Expr.VectorInputBindingInspe
}
}
+ /**
+ * SQL function "x IS NOT DISTINCT FROM y". Very similar to "x = y", i.e.
{@link BinEqExpr}, except this function
+ * never returns null, and this function considers NULL itself to be
not-distinct-from NULL.
Review Comment:
Hmm, maybe adding an example helps too. I changed it to this:
```
/**
* SQL function "x IS NOT DISTINCT FROM y". Very similar to "x = y", i.e.
{@link BinEqExpr}, except this function
* never returns null, and this function considers NULL as a value, so
NULL itself is not-distinct-from NULL. For
* example: `x == null` returns `null` in SQL-compatible null handling
mode, but `notdistinctfrom(x, null)` is
* true if `x` is null.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
